-
Notifications
You must be signed in to change notification settings - Fork 70
Update GH Actions macOS runner, update cibuildwheel for Python 3.14 build, add support for Cython 3.1.x, 3.2.x #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Thanks for this @mkoeppe and sorry for the delay in looking at it. I just glanced at it now and it looks good, but there are some failing test. Glancing at those, they look to be CVXPy issues, not CyLP issues. Any ideas how to get then passing? |
I'd suggest to run the GH Actions workflow on the master branch to check the baseline. I'm not sure if we're pinning CVXPy for these tests; likely it's caused by a CVXPy update or other updated packages |
|
Indeed, the result is the same in |
|
Indeed, running the tests from the installed cvxpy with |
|
I merged #224 and then tried to rebase your branch, but for some reason, I can't push to it, even though this PR is open. Instead, I just opened and closed the PR to re-run tests. If you want to rebase on master and force push, that might be cleaner. |
…se of Python 2 'long'
8270d8f to
158edf6
Compare
|
Rebased. |
Might be because I opened the PR from an org repository, rather than a personal repository |
|
Looks good now! |
The
macos-13runners are deprecated and will disappear by end of 2025. Replacement:macos-15-intel.